Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable C++ exceptions when compile for wasm32-wasi #192

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

glebpom
Copy link
Contributor

@glebpom glebpom commented Oct 12, 2021

Currently wasm32-wasi doesn't support exceptions

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@glebpom glebpom force-pushed the wasm32-no-exceptions branch 3 times, most recently from 3171ba8 to 77f5cbd Compare October 12, 2021 14:32
@glebpom glebpom force-pushed the wasm32-no-exceptions branch from 77f5cbd to 253b307 Compare October 12, 2021 15:35
@maxbrunsfeld
Copy link
Contributor

Thanks! We should actually disable exceptions for all C++ files in Tree-sitter parsers, regardless of what target you're compiling for. But this is fine for now.

@maxbrunsfeld maxbrunsfeld merged commit 1fedb2a into tree-sitter:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants