New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use windows-2019 for now #209

Merged

maxbrunsfeld merged 1 commit into tree-sitter:master from aibaars:windows-2019

Apr 20, 2022

Contributor

aibaars commented Apr 20, 2022 •

edited

Loading

@maxbrunsfeld This PR fixes the CI failures on windows but running the jobs on windows-2019.

See also: https://github.blog/changelog/2021-11-16-github-actions-windows-server-2022-with-visual-studio-2022-is-now-generally-available-on-github-hosted-runners/

I think a better fix would be to upgrade node-gyp upstream to a version that works with Visual Studio 2022, but this should work for now.

Checklist:

All tests pass in CI.
There are sufficient tests for the new fix/feature.
Grammar rules have not been renamed unless absolutely necessary.
The conflicts section hasn't grown too much.
The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).


          CI: use windows-2019 for now

a07ee83

Contributor

maxbrunsfeld commented Apr 20, 2022

Nice, thanks for fixing this.

maxbrunsfeld merged commit 7a9aaf6 into tree-sitter:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet