Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tree-sitter version to 0.20 #214

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

hendrikvanantwerpen
Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen commented Apr 28, 2022

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@@ -25,7 +25,7 @@ include = [
path = "bindings/rust/lib.rs"

[dependencies]
tree-sitter = "0.19"
tree-sitter = ">= 0.19, < 0.21"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is already present in the recently merged f0995f0

Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I double-checked that running npx tree-sitter-cli generate does not change the generated code.

@hendrikvanantwerpen
Copy link
Contributor Author

Thanks for verifying that, @aibaars! I found that any CLI devDependencies are on the PATH for the scripts in package.json that are run via npm run, and using npx explicitly is not necessary.

@hendrikvanantwerpen hendrikvanantwerpen merged commit adec59e into master Apr 29, 2022
@hendrikvanantwerpen hendrikvanantwerpen deleted the update-tree-sitter-version branch April 29, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants