Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to the parser #222

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Some improvements to the parser #222

merged 3 commits into from
Jul 20, 2022

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jun 30, 2022 •
edited
Loading

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aibaars aibaars marked this pull request as ready for review June 30, 2022 15:15
aryx
aryx reviewed Jun 30, 2022
View reviewed changes
script/known_failures.txt Outdated Show resolved Hide resolved
@aibaars aibaars requested a review from aryx July 2, 2022 10:48
dcreager
dcreager approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@dcreager dcreager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@aibaars aibaars merged commit e75d044 into tree-sitter:master Jul 20, 2022
@aibaars aibaars mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcreager dcreager dcreager approved these changes

@aryx aryx Awaiting requested review from aryx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aibaars @dcreager @aryx