Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pydantic #109

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Remove Pydantic #109

merged 5 commits into from
Aug 14, 2023

Conversation

alex-treebeard
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #109 (2775424) into main (966edac) will increase coverage by 0.50%.
Report is 36 commits behind head on main.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   92.46%   92.97%   +0.50%     
==========================================
  Files           4        4              
  Lines         146      185      +39     
==========================================
+ Hits          135      172      +37     
- Misses         11       13       +2     
Files Changed Coverage Δ
src/nbmake/pytest_plugin.py 91.66% <83.33%> (-3.08%) ⬇️
src/nbmake/nb_run.py 94.62% <93.10%> (+0.77%) ⬆️
src/nbmake/nb_result.py 100.00% <100.00%> (ø)
src/nbmake/pytest_items.py 89.28% <100.00%> (+0.82%) ⬆️

@alex-treebeard alex-treebeard changed the title build fix Remove Pydantic Aug 14, 2023
@alex-treebeard alex-treebeard merged commit 2533b2b into main Aug 14, 2023
@alex-treebeard alex-treebeard deleted the alex/build-fix branch August 14, 2023 10:32
garrison added a commit to Qiskit/qiskit-addon-cutting that referenced this pull request Mar 21, 2024
nbmake < 1.4.3 depends on pydantic < 2.0 (see
treebeardtech/nbmake#109), but
qiskit-ibm-runtime implicitly requires pydantic > 2.5
(see Qiskit/qiskit-ibm-runtime#1539).
garrison added a commit to Qiskit/qiskit-addon-cutting that referenced this pull request Mar 25, 2024
* Add support for `SamplerV2`

Fixes #488

* Use qiskit branch with fixed `BackendSamplerV2`

* Bump qiskit-aer version; restore qiskit version bounds

* Update pyproject.toml

* Update pyproject.toml

* Update pyproject.toml

* Bump nbmake minimum version

nbmake < 1.4.3 depends on pydantic < 2.0 (see
treebeardtech/nbmake#109), but
qiskit-ibm-runtime implicitly requires pydantic > 2.5
(see Qiskit/qiskit-ibm-runtime#1539).

* Revert "Update pyproject.toml"

This reverts commit b4de1c2.

* Update README, pyproject.toml

* Mark SamplerV2 branch as `pragma: no cover`

This annotation can be removed once qiskit 1.1 is released

* Updates

* Tweak release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant