fix:Modify usa local json file city name for fix download url append …

[mushroom11s]

Fix: modify the city name of the US local JSON file to fix the download URL append error.

[treee111]

Hi @mushroom11s,
thanks for this PR! 👍

What is the command / UI action causing the tool to break?
I assume the error is because of the URL creation here:

wahooMapsCreator/wahoomc/downloader.py

Lines 78 to 89 in 26968e5

	def build_url_for_country_osm_pbf_download(country):
	"""
	build the geofabrik download url to a countries' OSM file
	"""
	transl_c = const_fct.translate_country_input_to_geofabrik(country)
	region = const_fct.get_geofabrik_region_of_country(country)
	if region != 'no':
	url = 'https://download.geofabrik.de/' + region + \
	'/' + transl_c + '-latest.osm.pbf'
	else:
	url = 'https://download.geofabrik.de/' + transl_c + '-latest.osm.pbf'
	return url

We could manage the conversion of _ to - you done in the json-files to be consistent in the Translate_Country mapping.

wahooMapsCreator/wahoomc/constants.py

Lines 24 to 31 in 26968e5

	Translate_Country = {
	'alaska': 'united_states_of_america',
	'anguilla': 'central-america',
	'bahrain': 'gcc-states',
	'bosnia_and_herzegovina': 'bosnia-herzegovina',
	'british_virgin_islands': 'central-america',
	'british_indian_ocean_territory': 'asia',
	'brunei': 'malaysia-singapore-brunei',

We might have less changes because each "country" needs only one change and not each occurrence.
Let's see if that would help and is OK for you! :-)

[treee111]

OK, I got it.

If I use your branch and call python -m wahoomc cli -co american_samoa I still get this error:

The mapping of the input to the geofabrik name of the country is needed. As mentioned before this would make the changes of the json files obsolete in my opinion.

I done the change as suggested by me in the comment above.
Could you please checkout if branch fix-usa_local_json_cityname_error-via-constants works for you for american_samoa.
If you like, you can takeover the changes to your branch and change the other countries in the same way.

Greetings :-)

[mushroom11s]

Yes, I got this error when i downloading the map of Massachusetts,and then i found that many cities name are the same

[mushroom11s]

All names that contain underlined cities have problems

Yes, I made this error downloading the map of Massachusetts,and then i found that many cities name are the same

[treee111]

Hi @mushroom11s, thanks again for pointing out this _ to - thing!
I implemented the presented solution in #137
feel free to test it on branch develop :-)