Draft for adding insecure certificates option

src/puppy.nim

@@ -36,15 +36,17 @@ proc newRequest*(
   url: string,
   verb = "get",
   headers = newSeq[Header](),
-  timeout: float32 = 60
+  timeout: float32 = 60,
+  insecure: bool = false,
 ): Request =
   ## Allocates a new request object with defaults.
   result = Request()
   result.url = parseUrl(url)
   result.verb = verb
   result.headers = headers
   result.timeout = timeout
-
+  result.insecure = insecure
+
 proc fetch*(url: string, headers = newSeq[Header]()): string =
   let
     req = newRequest(url, "get", headers)

src/puppy/common.nim

@@ -1,35 +1,30 @@
 import urlly, strutils
-
 export urlly
-
 const CRLF* = "\r\n"
-
 type
   Header* = object
     key*: string
     value*: string
-
   Request* = ref object
     url*: Url
     headers*: seq[Header]
     timeout*: float32
     verb*: string
     body*: string
+    when defined(puppyLibcurl) or (defined(windows) or not defined(macosx)):
+      allowAnyHttpsCertificate*: bool
 
   Response* = ref object
     headers*: seq[Header]
     code*: int
     body*: string
-
   PuppyError* = object of IOError ## Raised if an operation fails.
-
 proc `[]`*(headers: seq[Header], key: string): string =
   ## Get a key out of headers. Not case sensitive.
   ## Use a for loop to get multiple keys.
   for header in headers:
     if header.key.toLowerAscii() == key.toLowerAscii():
       return header.value
-
 proc `[]=`*(headers: var seq[Header], key, value: string) =
   ## Sets a key in the headers. Not case sensitive.
   ## If key is not there appends a new key-value pair at the end.
@@ -38,6 +33,5 @@ proc `[]=`*(headers: var seq[Header], key, value: string) =
       header.value = value
       return
   headers.add(Header(key: key, value: value))
-
 proc `$`*(req: Request): string =
-  req.verb.toUpperAscii & " " & $req.url
+  req.verb.toUpperAscii & " " & $req.url

src/puppy/platforms/linux/platform.nim

@@ -16,29 +16,27 @@ proc fetch*(req: Request): Response {.raises: [PuppyError].} =
     count: int,
     outstream: pointer
   ): int {.cdecl.} =
-    if size != 1:
-      raise newException(PuppyError, "Unexpected curl write callback size")
     let
       outbuf = cast[ptr StringWrap](outstream)
       i = outbuf.str.len
     outbuf.str.setLen(outbuf.str.len + count)
     copyMem(outbuf.str[i].addr, buffer, count)
     result = size * count
-
+   
   {.pop.}
-
+  
   var strings: seq[string]
   strings.add $req.url
   strings.add req.verb.toUpperAscii()
   for header in req.headers:
     strings.add header.key & ": " & header.value
-
+  
   let curl = easy_init()
-
+  
   discard curl.easy_setopt(OPT_URL, strings[0].cstring)
   discard curl.easy_setopt(OPT_CUSTOMREQUEST, strings[1].cstring)
   discard curl.easy_setopt(OPT_TIMEOUT, req.timeout.int)
-
+  
   # Create the Pslist for passing headers to curl manually. This is to
   # avoid needing to call slist_free_all which creates problems
   var slists: seq[Slist]
@@ -54,32 +52,36 @@ proc fetch*(req: Request): Response {.raises: [PuppyError].} =
       while tail.next != nil:
         tail = tail.next
       tail.next = slists[i].addr
-
+  
   discard curl.easy_setopt(OPT_HTTPHEADER, headerList)
-
+  
   if req.verb.toUpperAscii() == "POST" or req.body.len > 0:
     discard curl.easy_setopt(OPT_POSTFIELDSIZE, req.body.len)
     discard curl.easy_setopt(OPT_POSTFIELDS, req.body.cstring)
-
+  
   # Setup writers.
   var headerWrap, bodyWrap: StringWrap
   discard curl.easy_setopt(OPT_WRITEDATA, bodyWrap.addr)
   discard curl.easy_setopt(OPT_WRITEFUNCTION, curlWriteFn)
   discard curl.easy_setopt(OPT_HEADERDATA, headerWrap.addr)
   discard curl.easy_setopt(OPT_HEADERFUNCTION, curlWriteFn)
-
+  
   # On windows look for cacert.pem.
   when defined(windows):
     discard curl.easy_setopt(OPT_CAINFO, "cacert.pem".cstring)
   # Follow redirects by default.
   discard curl.easy_setopt(OPT_FOLLOWLOCATION, 1)
 
+  if req.allowAnyHttpsCertificate:
+    discard curl.easy_setopt(OPT_SSL_VERIFYPEER, 0)
+    discard curl.easy_setopt(OPT_SSL_VERIFYHOST, 0)
+
   let
     ret = curl.easy_perform()
     headerData = headerWrap.str
-
+  
   curl.easy_cleanup()
-
+  
   if ret == E_OK:
     var httpCode: uint32
     discard curl.easy_getinfo(INFO_RESPONSE_CODE, httpCode.addr)
@@ -95,4 +97,4 @@ proc fetch*(req: Request): Response {.raises: [PuppyError].} =
       except ZippyError as e:
         raise newException(PuppyError, "Error uncompressing response", e)
   else:
-    raise newException(PuppyError, $easy_strerror(ret))
+    raise newException(PuppyError, $easy_strerror(ret))

src/puppy/platforms/macos/macdefs.nim

@@ -42,6 +42,7 @@ objc:
   proc setHTTPMethod*(self: NSMutableURLRequest, _: NSString)
   proc setValue*(self: NSMutableURLRequest, _: NSString, forHTTPHeaderField: NSString)
   proc setHTTPBody*(self: NSMutableURLRequest, _: NSData)
+  proc setAllowsAnyHTTPSCertificate*(self: NSMutableURLRequest)
   proc sendSynchronousRequest*(
     class: typedesc[NSURLConnection],
     _: NSMutableURLRequest,

src/puppy/platforms/macos/platform.nim

@@ -18,6 +18,9 @@ proc fetch*(req: Request): Response {.raises: [PuppyError].} =
     if req.body.len > 0:
       request.setHTTPBody(NSData.dataWithBytes(req.body[0].addr, req.body.len))
 
+    if req.insecure:
+      request.setAllowsAnyHTTPSCertificate()
+
     var
       response: NSHTTPURLResponse
       error: NSError