Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard input on macos #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

elcritch
Copy link

Turns out that NSApplication doesn't send keyUp events when command or other modifiers are being held down. Seems really weird, but it's an old issue.

This means Windy can't remove the non-modifier keys released before modifiers are released.

Here's some background info:

Initially I tried to follow their approaches of sub-classing NSApplication. However, it seems Window uses a global NSApp. Instead, since Windy already handles all events in pollEvents that was much simpler to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant