Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that NSApplication doesn't send
keyUp
events whencommand
or other modifiers are being held down. Seems really weird, but it's an old issue.This means Windy can't remove the non-modifier keys released before modifiers are released.
Here's some background info:
Initially I tried to follow their approaches of sub-classing NSApplication. However, it seems Window uses a global
NSApp
. Instead, since Windy already handles all events inpollEvents
that was much simpler to implement.