-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: markdown render for thread author #3
Conversation
panda2134
commented
Jun 21, 2020
- math not supported, will add KaTeX support later
- not tested
Tested on pkuhole community fork, not working😢 because the text is rendered as text, not HTML. |
we then need some "dangerouslySetInnerHTML " thing... |
Sorry for the bug, I'm familiar with Vuejs, but not so familiar with React |
之前修了一下,但是修改在Common.js,除了洞主的内容,回复也一并渲染了……在这里贴了一张图。 |
拿react-markdown重新弄了下,兼容了原来的几条渲染规则 @Yixuan-Wang 能否帮忙测试一下?我这边没有测试的环境 应该洞主渲染是正常的了 |
另外,我这边测试也不太方便🤦,两边代码库和代码风格差异太大,冲突太多…… |
感谢您的测试,洞号内链我大概知道是什么问题了,等会来修;图片可否考虑先禁止掉?毕竟已经有图片类型树洞了 |
1,3均已经修复 |
出于布局考虑,是否应该把markdown 中的h1,h2也渲染为h3? |
|
估计是过于严格地遵守了md规范 应该改一个比较宽松的格式 |
fixed via a19f1f2
On Mon, Jun 22, 2020 at 19:15, thuhole <notifications@github.com> wrote:
现存置顶洞的换行都没了。。。
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
坏了坏了,网站挂了,建议立刻revert |
应该是动了packages.json导致改变了cdn路径,但是travis ci没有对应改过来 |
抱歉刚刚紧急revert了 |
我CDN的部署非常的tricky,可以看.travis.yml |
package.json里的CDN也是非标准操作 |
我来手动merge吧 |
@panda2134 react-markdown的依赖应该可以去掉吧? |
成功了。下一步可能就要加markdown preview了哈哈哈哈。。又多了个锅 |
顺便,应该没有xss注入问题吧? |
本地测试是没有On Mon, Jun 22, 2020 at 19:57, thuhole <notifications@github.com> wrote:
顺便,应该没有xss注入问题吧?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
可以去掉react-markdown的依赖之前commit比较急,没有清理依赖文件On Mon, Jun 22, 2020 at 19:46, thuhole <notifications@github.com> wrote:
@panda2134 react-markdown的依赖应该可以去掉吧?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
已经有用户要求加预览了hhhh |
[图片] 可否显示链接? |
可以倒是可以,但是为啥不直接用链接呢hhh anyway我来加上吧 顺便做一下预览 |
我新开一个pr 过去说吧 |
@panda2134 算了,我觉得这样也可以,做个文档说明一下就行了。 |
@panda2134 其实最迫切需要的还是preview哈哈哈哈。。明天再说吧。 |
这个禁用得好啊,不知道为什么 waylonflinn/markdown-it-katex#26 到现在都还open |