bugfixes & highlight #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可能需要刷一下cdn，对字体有改动 |
|
|
|
高亮。可以直接以```开头，修了评论区由于开头的评论者身份带来的md渲染Bug |
|
这个渲染空树洞和只有空格的树洞，会有黑屏问题嘛 |
现在应该是不会了，可能还是得测试下 我昨天晚上把环境清了，要不你来测吧 |
|
好，我来测 |
thuhole
reviewed
Jun 23, 2020
| const parser = new HtmlToReact.Parser() | ||
|
|
||
| return parser.parseWithInstructions(renderedMarkdown, node => node.type !== 'script', processInstructions) | ||
| if (props.author && props.text.match(/^(?:#+ |>|```|\t|\s*-|\s*\d+\.)/)) { |
|
这个是把回复中第一行出现h1什么的特判掉，应该没有别的情况了？可能应该添加个$$On Tue, Jun 23, 2020 at 10:54, thuhole <notifications@github.com> wrote:
@thuhole commented on this pull request.
In src/Common.js:
const parser = new HtmlToReact.Parser()
-
- return parser.parseWithInstructions(renderedMarkdown, node => node.type !== 'script', processInstructions)
+ if (props.author && props.text.match(/^(?:#+ |>|```|\t|\s*-|\s*\d+\.)/)) {
这个regex会不会出什么特殊情况之类
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@panda2134 很奇怪，为什么外链本地测试可以，服务器暂时不行。。。我估计是CDN的问题 |
|
动了字体文件，需要清空cdn cacheOn Tue, Jun 23, 2020 at 11:02, thuhole <notifications@github.com> wrote:
@panda2134 很奇怪，为什么外链本地测试可以，push上去暂时不行。。。我估计是CDN的问题
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
已经确认了，是 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.