use functools.cached_property on >=3.12 #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also removes shortuuid, and uses `tmp_fname` from `dvc_objects`. - After removing funcy.cached_property, the only use of funcy was for `split`, which has been refactored as well. So, we also don't need to depend on funcy now.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 63.04% 63.09% +0.04%
==========================================
Files 62 62
Lines 4338 4341 +3
Branches 733 735 +2
==========================================
+ Hits 2735 2739 +4
+ Misses 1446 1445 -1
Partials 157 157 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes shortuuid, and uses
tmp_fnamefromdvc_objects.uuidwas only used for tmp files duringunprotect. Usingtmp_fname()will make it consistent with other operations.After removing funcy.cached_property, the only use of funcy was for
split, which has been refactored as well. So, we also don't need to depend on funcy now.Similar to what was done in treeverse/dvc-objects#269 and /treeverse/dvc-objects#270.