Skip to content

gc: log paths during dry-run #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skshetry merged 1 commit into from
Jan 7, 2026
Merged

gc: log paths during dry-run #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/dvc_data/hashfile/gc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
import logging
from collections.abc import Iterable
from typing import TYPE_CHECKING, Optional

if TYPE_CHECKING:
from .db import HashFileDB
from .hash_info import HashInfo

logger = logging.getLogger(__name__)

def gc( # noqa: C901

def gc( # noqa: C901, PLR0912
odb: "HashFileDB",
used: Iterable["HashInfo"],
jobs: Optional[int] = None,
Expand Down Expand Up @@ -55,7 +58,10 @@ def _is_dir_hash(_hash):
for paths in (dir_paths, file_paths):
if paths:
num_removed += len(paths)
if not dry:
if dry:
for path in paths:
logger.info("Removing %s", path)
else:
odb.fs.remove(paths)

return num_removed