-
Notifications
You must be signed in to change notification settings - Fork 405
docs: misc. updates #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: misc. updates #1680
Conversation
shcheklein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving. there are some suggestions in the comments
|
Sorry @shcheklein , I added more stuff to this PR before realizing you had already approved it. Please check once more. Won't add anything else. |
shcheklein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few unresolved issues here
| example: | ||
|
|
||
| ```dvc | ||
| $ dvc remote modify myremote url /home/user/dvcstore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do s3 example and can even explain about s3 prefix, or do another example if needed in a separate block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK added S3 example before local example although I'm not sure it's needed as it's also in the S3 section. The S3 URL format is also explained in its section. See 3b7898e
shcheklein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall - some comments still to address, approving so that you can merge when you see it's done more or less
Uh oh!
There was an error while loading. Please reload this page.