Skip to content

Conversation

@jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Aug 8, 2020

@shcheklein shcheklein temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:11 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:16 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:24 Inactive
@jorgeorpinel jorgeorpinel changed the title cmd: rewrite sections about remote URLs cmd: rewrite sections and short descs. about URLs (remote, get/import-url) Aug 8, 2020
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. there are some suggestions in the comments

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 00:44 Inactive
@jorgeorpinel jorgeorpinel changed the title cmd: rewrite sections and short descs. about URLs (remote, get/import-url) docs: misc. updates Aug 10, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 03:39 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 04:14 Inactive
@jorgeorpinel
Copy link
Contributor Author

Sorry @shcheklein , I added more stuff to this PR before realizing you had already approved it. Please check once more. Won't add anything else.

Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few unresolved issues here

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 05:23 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 22:53 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 22:55 Inactive
example:

```dvc
$ dvc remote modify myremote url /home/user/dvcstore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do s3 example and can even explain about s3 prefix, or do another example if needed in a separate block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK added S3 example before local example although I'm not sure it's needed as it's also in the S3 section. The S3 URL format is also explained in its section. See 3b7898e

Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall - some comments still to address, approving so that you can merge when you see it's done more or less

jorgeorpinel added a commit that referenced this pull request Aug 12, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 13, 2020 03:49 Inactive
@jorgeorpinel jorgeorpinel merged commit 4ed790d into master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: insufficient description of params

3 participants