Fix #697: Make unexisting docs pages return 404 status #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
approved these changes
Dec 17, 2019
shcheklein
suggested changes
Dec 17, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
utils/sidebar.json is a strange location for the file? can we move it anywhere at all?
Contributor
|
I tested the deployment and it works, thanks @iAdramelk! Seems like we just have minor concerns here 🙂 ^ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Updated names and locations:
Also updated path to |
shcheklein
approved these changes
Dec 18, 2019
jorgeorpinel
suggested changes
Dec 18, 2019
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Just pending resolving #872 (review)
jorgeorpinel
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #697. Add check for /doc pages in
server.js, if page does not exists, it return correct status.