Skip to content

Conversation

@fabiosantoscode
Copy link
Contributor

@fabiosantoscode fabiosantoscode commented Jan 23, 2020

No ticket associated, just noticed that the Circle build is failing and am sending a fix.


Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.

Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏

@shcheklein
Copy link
Contributor

@fabiosantoscode thanks! the good question is why didn't we catch it. Would be great to check the history.

@shcheklein shcheklein merged commit dea3ef3 into treeverse:master Jan 23, 2020
@jorgeorpinel
Copy link
Contributor

It was me (d2960b0) but I can't find the PR 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants