test: link-check against merge base #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
added
the
type: enhancement
shcheklein
approved these changes
Feb 7, 2020
jorgeorpinel
reviewed
Feb 7, 2020
| #!/usr/bin/env bash | ||
| set -euxo pipefail | ||
| $(dirname "$0")/link-check.sh <(git diff origin/master -U0) | ||
| $(dirname "$0")/link-check.sh <(git diff $(git merge-base HEAD origin/master) -U0 | grep '^\+') |
Contributor
There was a problem hiding this comment.
Maybe you can just use lint-staged (used/configured in package.json) to sent the staged files into this script @casperdcl ?
Contributor
Author
There was a problem hiding this comment.
Can't because that would affect the pre-commit hook
Contributor
Author
There was a problem hiding this comment.
(and we can't assume devs have the prereqs to run the checks)
This was referenced Feb 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.