Skip to content

Regular updates (Feb 10+) #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shcheklein merged 4 commits into from
Feb 14, 2020
Merged

Regular updates (Feb 10+) #988

shcheklein merged 4 commits into from
Feb 14, 2020

Conversation

@jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 11, 2020 •
edited
Loading

@shcheklein shcheklein temporarily deployed to dvc-landing-2010-02-10-5lrc9c1 February 11, 2020 16:47 Inactive
shcheklein
shcheklein approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge it?

@jorgeorpinel

This comment has been minimized.

Sign in to view
@shcheklein

This comment has been minimized.

Sign in to view
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 14, 2020
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-5lrc9c1 February 14, 2020 03:36 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 14, 2020 03:41
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-5lrc9c1 February 14, 2020 04:08 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 14, 2020 •
edited
Loading

Sorry, I just wanted to throw in a few more related changes. Ready for review and hopefully merge now, @shcheklein

shcheklein
shcheklein approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

@shcheklein shcheklein merged commit 8f2e4b3 into master Feb 14, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@jorgeorpinel jorgeorpinel deleted the 2010-02-10 branch March 21, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shcheklein shcheklein shcheklein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgeorpinel @shcheklein