dvc add produces /tmp in .dvc/.gitignore

[RomanVeretenov]

dvc version 0.91.1
installed via pip on ubuntu 18.04

Each dvc add produces extra line '/tmp' in .dvc/.gitignore.

 % git diff .dvc/.gitignore

diff --git a/.dvc/.gitignore b/.dvc/.gitignore
index 9bd2370..cfd5c3c 100644
--- a/.dvc/.gitignore
+++ b/.dvc/.gitignore
@@ -10,3 +10,6 @@
 /tmp

 /tmp
+/tmp
+/tmp
+/tmp

[efiop]

@RomanVeretenov Does it happen after specific dvc command?

[efiop]

@RomanVeretenov Could you show us git check-ignore $(pwd)/.dvc/tmp output, please? Is there anything special about your repo location?

[shcheklein]

@efiop it happens on older repos. Try to clone our get started and run a few commands (pull, checkout, etc).

[RomanVeretenov]

@RomanVeretenov Could you show us git check-ignore $(pwd)/.dvc/tmp output, please? Is there anything special about your repo location?

output is empty

[efiop]

@shcheklein It does, but it only adds the missing /tmp(as it is supposed to be), not adding it multiple times as in this issue. I am not able to reproduce the issue.

@RomanVeretenov Ok, that is bad, it means that git is not seeing that /tmp in .gitignore or not understanding it right. Is there anything special about the location that your repo is located in?

Could you show:

$ python -c 'import os; print(os.getcwd())'
$ python -c 'import os; print(os.path.realpath(os.getcwd()))'

please?

So far this looks like there is something wrong with your environment or git specifically.

[RomanVeretenov]

$ python -c 'import os; print(os.getcwd())'
/home/ds
$ python -c 'import os; print(os.path.realpath(os.getcwd()))'
/home/ds

yep, the repo root is '/home/ds' =)

[efiop]

@RomanVeretenov Using /home/ds is questionable, but nothing functionally wrong about it 🙂 Looks alright. Maybe you have .dvc/ gitignored somewhere or something?

Need to check your .gitignores in /home and /home/ds to see if they are sane(maybe they have something like !!.dvc/tmp, !!tmp or something that forces git to not ignore .dvc/tmp. Would also check global gitignore rules, if you have those.

[RomanVeretenov]

There is no /home/.gitignore
Also I have no global gitignore
Also .git/info/exclude is empty

/home/ds % cat .gitignore

*.jpg
*.JPG
*.png
*.PNG
extracted.csv

also I have recursively listed all gitignore's
None of them but .dvc/.gitignore conatins tmp

find . -name '.gitignore' -exec echo {} \; -exec grep tmp {} \;
... here goes gitignores from all nested folders
./.dvc/.gitignore
/tmp
/tmp
./.gitignore
...

Each dvc status call adds a /tmp to the end of .dvc/.gitignore

[efiop]

@RomanVeretenov Could you try to reproduce it with a newly created dvc project? E.g.

mkdir myrepo
cd myrepo
git init
dvc init
git add .
git commit -m "init"
dvc status
git status

I'm still not able to reproduce your issue, most likely there is something off with your environment, can't put my finger on anything yet.

[RomanVeretenov]

@RomanVeretenov Could you try to reproduce it with a newly created dvc project? E.g.

mkdir myrepo
cd myrepo
git init
dvc init
git add .
git commit -m "init"
dvc status
git status

I'm still not able to reproduce your issue, most likely there is something off with your environment, can't put my finger on anything yet.

It works ok on a clean repo

 ~/code/myrepo/.dvc
 % cat .gitignore
/config.local
/updater
/lock
/updater.lock
/tmp
/state-journal
/state-wal
/state
/cache

after executing all given commands

[efiop]

It works ok on a clean repo

@RomanVeretenov So there is something with your .gitignores in the rest of the project. You'll have to take a look and see what is different between it and a clean one. It might be .gitignores somewhere, might be the fact that you are in /home/ds (esp if you are working as ds user), might be that you don't have permissions to access some files (again, if your git project is not owned by you and you don't have shared mode enabled in git config). But it is clear that this is not dvc-issue, it is your git repo and environment that are not quite right. Sorry, but you are pretty much on your own right now, as I can't put my finger on anything specific 🙁

[efiop]

Please let us know how it goes. I'll close this issue for now.