imp_url: make default stage fname accompany import target #3312
Conversation
|
|
||
| @staticmethod | ||
| def create(repo, **kwargs): | ||
| def create(repo, accompany_outs=False, **kwargs): |
There was a problem hiding this comment.
I was the one to introduce the kwargs instead of list of arguments, but it seems to me that I overdone that, arguments required in this method should be present in arguments list and if necessary, passed down. kwargs occludes what is necessary for this method.
skshetry
left a comment
skshetry
left a comment
There was a problem hiding this comment.
Looks good. I tried locally, and it worked. :)
|
Thanks!
Were you able to check this doesn't require doc updates? UPDATE: Not in examples, but I think the description of |
|
OK never mind, I included this in treeverse/dvc.org/pull/993 but please check the docs in future PRs before checking the box. Thanks! |
* cmd ref: add space after emoji intro in https://github.com/iterative/dvc.org/pull/951/files * term: under X control -> tracked by X (or similar) (1) for #719 * term: under X control -> tracked by X (or similar) (2) strings from core repo * term: add to -> add with (DVC) * cmd ref: update import -o behaviod explantation per treeverse/dvc/pull/3312
4 participants
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
Done in treeverse/dvc.org@c671bed
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #3304