Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jun 1, 2020

We will be re-introducing metrics modify in the future and
will likely revisit add/remove too, so it is better to get
rid of these for now and introduce later with a clear scneario
in mind.

Fixes #3849
Fixes #3907

Already removed from the docs.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

We will be re-introducing `metrics modify` in the future and
will likely revisit `add/remove` too, so it is better to get
rid of these for now and introduce later with a clear scneario
in mind.

Fixes treeverse#3849
Fixes treeverse#3907
@efiop efiop merged commit 86f3457 into treeverse:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metrics remove doesn't work for pipeline files metrics add: add does not convert output to metrics

1 participant