force YAML 1.1 syntax when dumping yaml files with ruamel#4295
Closed
dtrifiro wants to merge 1 commit intotreeverse:masterfrom
Closed
force YAML 1.1 syntax when dumping yaml files with ruamel#4295dtrifiro wants to merge 1 commit intotreeverse:masterfrom
dtrifiro wants to merge 1 commit intotreeverse:masterfrom
Conversation
dtrifiro
force-pushed
the
fix-lockfile-dumper
branch
from
38ee3c5 to
1d1dce1
Compare
Collaborator
|
Tests are failing because this workaround adds "% YAML 1.1` which is a yaml version directive to the start of the YAML files. We need to find some way to avoid this (but still dump in 1.1 version). |
Collaborator
|
just did a simple benchmarking for ruamel. It's twice as slow as pyyaml for |
skshetry
force-pushed
the
fix-lockfile-dumper
branch
from
1d1dce1 to
4cb04bb
Compare
skshetry
force-pushed
the
fix-lockfile-dumper
branch
from
4cb04bb to
afa4510
Compare
Contributor
Author
|
Development moved to #4380 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workaround for #4281