Skip to content

import: don't forget to set cache.dir #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 2 commits into from
May 7, 2023
Merged

import: don't forget to set cache.dir #9415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90637f1
import: don't forget to set cache.dir
efiop May 7, 2023
f89a6ff
repo: open: try setting remote for local repos
efiop May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dvc/dependency/repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def _make_fs(
url=self.def_repo[self.PARAM_URL],
rev=rev or self._get_rev(locked=locked),
subrepos=True,
config={"cache": {"dir": self.repo.cache.local.path}},
)

def _get_rev(self, locked: bool = True):
Expand Down
3 changes: 3 additions & 0 deletions dvc/repo/open_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def open_repo(url, *args, **kwargs):

if os.path.exists(url):
try:
config = _get_remote_config(url)
config.update(kwargs.get("config") or {})
kwargs["config"] = config
return Repo(url, *args, **kwargs)
except NotDvcRepoError:
pass # fallthrough to _external_repo
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/stage/test_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ def test_path_conversion(dvc):


def test_stage_update(dvc, mocker):
dep = RepoDependency({"url": "example.com"}, None, "dep_path")
stage = Stage(dvc, "path", "cmd")
dep = RepoDependency({"url": "example.com"}, stage, "dep_path")
mocker.patch.object(dep, "update", return_value=None)

stage = Stage(dvc, "path", deps=[dep])
Expand Down