Error on Azure async copy (#1738)

treeverse · Apr 8, 2021 · 1a24fb1 · 1a24fb1
1 parent 65b180c
commit 1a24fb1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/go.yaml b/.github/workflows/go.yaml
@@ -35,7 +35,7 @@ jobs:
         env:
           GOLANGCI_LINT_FLAGS: --out-format github-actions
       - name: gitLeaks
-        uses: zricethezav/gitleaks-action@v1.3.0
+        uses: zricethezav/gitleaks-action@v1.5.0
 
   test:
     name: Run Test Suite

diff --git a/pkg/block/azure/adapter.go b/pkg/block/azure/adapter.go
@@ -18,6 +18,7 @@ import (
 
 var (
 	ErrNotImplemented = errors.New("not implemented")
+	ErrAsyncCopy      = errors.New("asynchronous copy not supported")
 )
 
 const (
@@ -303,8 +304,16 @@ func (a *Adapter) Copy(ctx context.Context, sourceObj, destinationObj block.Obje
 
 	destinationContainer := a.getContainerURL(qualifiedDestinationKey.ContainerURL)
 	destinationURL := destinationContainer.NewBlobURL(qualifiedDestinationKey.BlobURL)
-	_, err = destinationURL.StartCopyFromURL(ctx, sourceURL.URL(), azblob.Metadata{}, azblob.ModifiedAccessConditions{}, azblob.BlobAccessConditions{}, azblob.AccessTierNone, azblob.BlobTagsMap{})
-	return err
+	resp, err := destinationURL.StartCopyFromURL(ctx, sourceURL.URL(), azblob.Metadata{}, azblob.ModifiedAccessConditions{}, azblob.BlobAccessConditions{}, azblob.AccessTierNone, azblob.BlobTagsMap{})
+	if err != nil {
+		return err
+	}
+	// validate copy is not asynchronous
+	copyStatus := resp.CopyStatus()
+	if copyStatus == "pending" {
+		return ErrAsyncCopy
+	}
+	return nil
 }
 
 func (a *Adapter) CreateMultiPartUpload(ctx context.Context, obj block.ObjectPointer, _ *http.Request, _ block.CreateMultiPartUploadOpts) (string, error) {