Branch protection status code should be 403 (#5273)

* Branch protection status code should be 403 * apply code review changes * fix indent * fix dup Forbidden message type
treeverse · Feb 23, 2023 · 1c8481a · 1c8481a
1 parent 5371adb
commit 1c8481a
Show file tree

Hide file tree

Showing 21 changed files with 145 additions and 32 deletions.
diff --git a/api/swagger.yml b/api/swagger.yml
@@ -79,12 +79,6 @@ components:
         application/json:
           schema:
             $ref: "#/components/schemas/Error"
-    Forbidden:
-      description: Access is forbidden
-      content:
-        application/json:
-          schema:
-            $ref: "#/components/schemas/Error"
     NotFound:
       description: Resource Not Found
       content:
@@ -103,6 +97,12 @@ components:
         application/json:
           schema:
             $ref: "#/components/schemas/Error"
+    Forbidden:
+      description: Forbidden
+      content:
+        application/json:
+          schema:
+            $ref: "#/components/schemas/Error"
     ValidationError:
       description: Validation Error
       content:
@@ -2592,6 +2592,8 @@ paths:
           $ref: "#/components/responses/ValidationError"
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         default:
@@ -2643,6 +2645,8 @@ paths:
           description: branch deleted successfully
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         default:
@@ -2749,6 +2753,8 @@ paths:
           $ref: "#/components/responses/ValidationError"
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         409:
@@ -3286,6 +3292,8 @@ paths:
           $ref: "#/components/responses/ValidationError"
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         412:
@@ -3302,6 +3310,8 @@ paths:
           description: object deleted successfully
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         default:
@@ -3339,6 +3349,8 @@ paths:
                 $ref: "#/components/schemas/ObjectErrorList"
         401:
           $ref: "#/components/responses/Unauthorized"
+        403:
+          $ref: "#/components/responses/Forbidden"
         404:
           $ref: "#/components/responses/NotFound"
         default:

diff --git a/clients/java/api/openapi.yaml b/clients/java/api/openapi.yaml
diff --git a/clients/java/docs/BranchesApi.md b/clients/java/docs/BranchesApi.md
diff --git a/clients/java/docs/CommitsApi.md b/clients/java/docs/CommitsApi.md
diff --git a/clients/java/docs/ImportApi.md b/clients/java/docs/ImportApi.md
diff --git a/clients/java/docs/ObjectsApi.md b/clients/java/docs/ObjectsApi.md
diff --git a/clients/java/docs/RefsApi.md b/clients/java/docs/RefsApi.md
diff --git a/clients/java/src/main/java/io/lakefs/clients/api/BranchesApi.java b/clients/java/src/main/java/io/lakefs/clients/api/BranchesApi.java
diff --git a/clients/java/src/main/java/io/lakefs/clients/api/CommitsApi.java b/clients/java/src/main/java/io/lakefs/clients/api/CommitsApi.java
diff --git a/clients/java/src/main/java/io/lakefs/clients/api/ImportApi.java b/clients/java/src/main/java/io/lakefs/clients/api/ImportApi.java