Silence checks warning: don't try to pass difference by reference

Code was correct, but efficiency might not matter here.
treeverse · Oct 14, 2020 · 40643a7 · 40643a7
1 parent ed47a62
commit 40643a7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/export/tasks_generator.go b/export/tasks_generator.go
@@ -120,7 +120,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif
 		toSignal []parade.TaskID
 	})
 
-	makeTaskForDiff := func(diff *catalog.Difference) (parade.TaskData, error) {
+	makeTaskForDiff := func(diff catalog.Difference) (parade.TaskData, error) {
 		var (
 			body     []byte
 			action   string
@@ -187,7 +187,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif
 			return nil, fmt.Errorf("no \"Path\" in %+v: %w", diff, ErrMissingColumns)
 		}
 
-		task, err := makeTaskForDiff(&diff)
+		task, err := makeTaskForDiff(diff)
 		if err != nil {
 			return nil, err
 		}
@@ -233,7 +233,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif
 		}
 
 		ret = append(ret, parade.TaskData{
-			ID:                parade.TaskID(makeSuccessTaskID(successDirectory)),
+			ID:                makeSuccessTaskID(successDirectory),
 			Action:            TouchAction,
 			Body:              &bodyStr,
 			StatusCode:        parade.TaskPending,