fix tests

pkg/api/controller.go

@@ -3091,9 +3091,10 @@ func (c *Controller) InternalCreateBranchProtectionRule(w http.ResponseWriter, r
 		}
 	}
 	if rules == nil {
-		rules = &graveler.BranchProtectionRules{
-			BranchPatternToBlockedActions: make(map[string]*graveler.BranchProtectionBlockedActions),
-		}
+		rules = &graveler.BranchProtectionRules{}
+	}
+	if rules.BranchPatternToBlockedActions == nil {
+		rules.BranchPatternToBlockedActions = make(map[string]*graveler.BranchProtectionBlockedActions)
 	}
 	blockedActions := &graveler.BranchProtectionBlockedActions{
 		Value: []graveler.BranchProtectionBlockedAction{graveler.BranchProtectionBlockedAction_STAGING_WRITE, graveler.BranchProtectionBlockedAction_COMMIT},

pkg/graveler/branch/protection_manager_test.go

@@ -28,8 +28,9 @@ func TestSetAndGet(t *testing.T) {
 	ctx := context.Background()
 	bpm := prepareTest(t, ctx)
 	rules, eTag, err := bpm.GetRules(ctx, repository)
-	if !errors.Is(err, graveler.ErrNotFound) {
-		t.Fatalf("expected ErrNotFound, got %v", err)
+	testutil.Must(t, err)
+	if len(rules.BranchPatternToBlockedActions) != 0 {
+		t.Fatalf("expected no rules, got %d rules", len(rules.BranchPatternToBlockedActions))
 	}
 	testutil.Must(t, bpm.SetRulesIf(ctx, repository, &graveler.BranchProtectionRules{
 		BranchPatternToBlockedActions: map[string]*graveler.BranchProtectionBlockedActions{
@@ -90,8 +91,9 @@ func TestDelete(t *testing.T) {
 	testutil.Must(t, bpm.Delete(ctx, repository, "main*"))
 
 	rules, _, err = bpm.GetRules(ctx, repository)
-	if !errors.Is(err, graveler.ErrNotFound) {
-		t.Fatalf("expected ErrNotFound after delete, got %v", err)
+	testutil.Must(t, err)
+	if len(rules.BranchPatternToBlockedActions) != 0 {
+		t.Fatalf("expected no rules, got %d rules", len(rules.BranchPatternToBlockedActions))
 	}
 }