Skip to content

Commit

Permalink
CR fixes for previous merge (#1116)
Browse files Browse the repository at this point in the history
  • Loading branch information
johnnyaug authored Dec 28, 2020
1 parent d118015 commit 5db4690
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/reference/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ This reference uses `.` to denote the nesting of values.
(`*.s3.local.lakefs.io` always resolves to 127.0.0.1, useful for
local development
* `gateways.s3.region` `(string : "us-east-1")` - AWS region we're pretending to be. Should match the region configuration used in AWS SDK clients
* `gateways.s3.fallback_url` `(string)` - If specified, requests with a non-existing repository will be forwarded to this url.
* `gateways.s3.fallback_url` `(string)` - If specified, requests with a non-existing repository will be forwarded to this url. This can be useful for using lakeFS side-by-side with S3, with the URL pointing at an [S3Proxy](https://github.com/gaul/s3proxy) instance.
* `stats.enabled` `(boolean : true)` - Whether or not to periodically collect anonymous usage statistics
{: .ref-list }

Expand Down
4 changes: 2 additions & 2 deletions gateway/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ func RepoOperationHandler(sc *ServerContext, repoID string, handler operations.R
repo, err := authOp.Cataloger.GetRepository(sc.ctx, repoID)
if errors.Is(err, db.ErrNotFound) {
if sc.fallbackProxy == nil {
authOp.Log().WithField("repository", repoID).Warn("the specified repo does not exist")
authOp.Log().WithField("repository", repoID).Debug("the specified repo does not exist")
authOp.EncodeError(gatewayerrors.ErrNoSuchBucket.ToAPIErr())
} else {
sc.fallbackProxy.ServeHTTP(writer, request)
Expand Down Expand Up @@ -320,7 +320,7 @@ func PathOperationHandler(sc *ServerContext, repoID, refID, path string, handler
repo, err := authOp.Cataloger.GetRepository(sc.ctx, repoID)
if errors.Is(err, db.ErrNotFound) {
if sc.fallbackProxy == nil {
authOp.Log().WithField("repository", repoID).Warn("the specified repo does not exist")
authOp.Log().WithField("repository", repoID).Debug("the specified repo does not exist")
authOp.EncodeError(gatewayerrors.ErrNoSuchBucket.ToAPIErr())
} else {
sc.fallbackProxy.ServeHTTP(writer, request)
Expand Down

0 comments on commit 5db4690

Please sign in to comment.