Fix gateway delete with branch protection should return 200 with error (

#7211) * Fix gateway delete with branch protection should return 200 with error Current implementation return no content status code after we render an error. * fix return after encode error
treeverse · Jan 1, 2024 · b53e7a7 · b53e7a7
1 parent a811d2d
commit b53e7a7
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/gateway/operations/deleteobject.go b/pkg/gateway/operations/deleteobject.go
@@ -77,8 +77,10 @@ func (controller *DeleteObject) Handle(w http.ResponseWriter, req *http.Request,
 		lg.WithError(err).Debug("could not delete object, it doesn't exist")
 	case errors.Is(err, graveler.ErrWriteToProtectedBranch):
 		_ = o.EncodeError(w, req, err, gatewayerrors.Codes.ToAPIErr(gatewayerrors.ErrWriteToProtectedBranch))
+		return
 	case errors.Is(err, graveler.ErrReadOnlyRepository):
 		_ = o.EncodeError(w, req, err, gatewayerrors.Codes.ToAPIErr(gatewayerrors.ErrReadOnlyRepository))
+		return
 	case err != nil:
 		lg.WithError(err).Error("could not delete object")
 		_ = o.EncodeError(w, req, err, gatewayerrors.Codes.ToAPIErr(gatewayerrors.ErrInternalError))