CR Fixes 2

treeverse · Nov 22, 2024 · bdcf023 · bdcf023
1 parent c5b5ad3
commit bdcf023
Show file tree

Hide file tree

Showing 15 changed files with 22 additions and 20 deletions.
diff --git a/api/swagger.yml b/api/swagger.yml
@@ -695,7 +695,7 @@ components:
           default: false
         hidden:
           type: boolean
-          description: *EXPERIMENTAL* When set, branch will not show up when listing branches by default.          
+          description: When set, branch will not show up when listing branches by default. *EXPERIMENTAL*          
           default: false
 
     TagCreation:

diff --git a/clients/java-legacy/api/openapi.yaml b/clients/java-legacy/api/openapi.yaml
diff --git a/clients/java-legacy/docs/BranchCreation.md b/clients/java-legacy/docs/BranchCreation.md
diff --git a/clients/java-legacy/src/main/java/io/lakefs/clients/api/model/BranchCreation.java b/clients/java-legacy/src/main/java/io/lakefs/clients/api/model/BranchCreation.java
diff --git a/clients/java/api/openapi.yaml b/clients/java/api/openapi.yaml
diff --git a/clients/java/docs/BranchCreation.md b/clients/java/docs/BranchCreation.md
diff --git a/clients/java/src/main/java/io/lakefs/clients/sdk/model/BranchCreation.java b/clients/java/src/main/java/io/lakefs/clients/sdk/model/BranchCreation.java
diff --git a/clients/python-legacy/docs/BranchCreation.md b/clients/python-legacy/docs/BranchCreation.md
diff --git a/clients/python-legacy/lakefs_client/model/branch_creation.py b/clients/python-legacy/lakefs_client/model/branch_creation.py
diff --git a/clients/python/docs/BranchCreation.md b/clients/python/docs/BranchCreation.md
diff --git a/clients/python/lakefs_sdk/models/branch_creation.py b/clients/python/lakefs_sdk/models/branch_creation.py
diff --git a/clients/rust/docs/BranchCreation.md b/clients/rust/docs/BranchCreation.md
diff --git a/clients/rust/src/models/branch_creation.rs b/clients/rust/src/models/branch_creation.rs
diff --git a/docs/assets/js/swagger.yml b/docs/assets/js/swagger.yml
@@ -695,7 +695,7 @@ components:
           default: false
         hidden:
           type: boolean
-          description: When set, branch will not show up when listing branches by default
+          description: When set, branch will not show up when listing branches by default. *EXPERIMENTAL*          
           default: false
 
     TagCreation:

diff --git a/pkg/api/controller_test.go b/pkg/api/controller_test.go
@@ -1502,8 +1502,9 @@ func TestController_ListBranchesHandler(t *testing.T) {
 		if len(results) != 2 {
 			t.Fatalf("expected 2 branches to return, got %d", len(results))
 		}
-		require.Equal(t, results[0].Id, "main3")
-		require.Equal(t, results[1].Id, "main5")
+		expectedRefs := []string{"main3", "main5"}
+		gotRefs := []string{results[0].Id, results[1].Id}
+		require.Equal(t, expectedRefs, gotRefs)
 
 		// List all branches
 		resp, err = clt.ListBranchesWithResponse(ctx, repo, &apigen.ListBranchesParams{
@@ -1516,8 +1517,9 @@ func TestController_ListBranchesHandler(t *testing.T) {
 		if len(results) != 2 {
 			t.Fatalf("expected 2 branches to return, got %d", len(results))
 		}
-		require.Equal(t, results[0].Id, "main2")
-		require.Equal(t, results[1].Id, "main3")
+		expectedRefs = []string{"main2", "main3"}
+		gotRefs = []string{results[0].Id, results[1].Id}
+		require.Equal(t, expectedRefs, gotRefs)
 	})
 
 	t.Run("list branches repo doesnt exist", func(t *testing.T) {