Handle no path for delete objects in gateway (#1708)

pkg/catalog/validate.go

@@ -21,8 +21,9 @@ var (
 )
 
 var (
-	ErrInvalidType   = errors.New("invalid type")
-	ErrRequiredValue = errors.New("required value")
+	ErrInvalidType       = errors.New("invalid type")
+	ErrRequiredValue     = errors.New("required value")
+	ErrPathRequiredValue = fmt.Errorf("missing path: %w", ErrRequiredValue)
 )
 
 type ValidateFunc func(v interface{}) error
@@ -171,7 +172,7 @@ func ValidatePath(v interface{}) error {
 	}
 	l := len(s.String())
 	if l == 0 {
-		return ErrRequiredValue
+		return ErrPathRequiredValue
 	}
 	if l > MaxPathLength {
 		return fmt.Errorf("%w: %d is above maximum length (%d)", ErrInvalidValue, l, MaxPathLength)

pkg/gateway/operations/deleteobjects.go

@@ -63,6 +63,11 @@ func (controller *DeleteObjects) Handle(w http.ResponseWriter, req *http.Request
 		switch {
 		case errors.Is(err, catalog.ErrNotFound):
 			lg.Debug("tried to delete a non-existent object")
+		case errors.Is(err, catalog.ErrPathRequiredValue):
+			// issue #1706 - https://github.com/treeverse/lakeFS/issues/1706
+			// Spark trying to delete the path "main/", which we map to branch "main" with an empty path.
+			// Spark expects it to succeed (not deleting anything is a success), instead of returning an error.
+			lg.Debug("tried to delete with an empty branch")
 		case err != nil:
 			lg.WithError(err).Error("failed deleting object")
 			errs = append(errs, serde.DeleteError{