Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local block adapter doesn't work with storage namespaces #935

Closed
arielshaqed opened this issue Nov 18, 2020 · 1 comment
Closed

local block adapter doesn't work with storage namespaces #935

arielshaqed opened this issue Nov 18, 2020 · 1 comment
Assignees

Comments

@arielshaqed
Copy link
Contributor

local.go Adapter.Put completely ignores the namespace of the passed-in object. So if a repo is created on some adapter, all files are actually stored in the same local directory regardless of the namespace.

Meanwhile export is unaware of this, and cannot find the file.

Apart from fixing export, we should either refuse to namespace on adapters that do not support it, or fix them to support it. (The latter may have backwards compatibility issues!)

@arielshaqed
Copy link
Contributor Author

@guy-har fixed this in #938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants