local adapter - respect namespace in objects full path

[guy-har]

No description provided.

[codecov-io]

Codecov Report

Merging #938 (6ad53c1) into master (99b0c86) will increase coverage by 0.16%.
The diff coverage is 36.73%.

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   44.21%   44.37%   +0.16%     
==========================================
  Files         143      143              
  Lines       11451    11483      +32     
==========================================
+ Hits         5063     5096      +33     
+ Misses       5769     5750      -19     
- Partials      619      637      +18     

Impacted Files	Coverage Δ
block/local/adapter.go	50.00% <36.73%> (+19.86%)	⬆️
config/logger.go	64.28% <0.00%> (-10.72%)	⬇️
catalog/cataloger_create_repository.go	59.25% <0.00%> (-7.41%)	⬇️
catalog/cataloger_commit.go	79.71% <0.00%> (-2.90%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b0c86...6ad53c1. Read the comment docs.

[arielshaqed]

Great, thanks! All the code is nice, tested, makes sense, and obviously approved.

There may be backwards-compatiblity issues that we should discuss. I suggest we put it out as a release note but not more - local storage is not currently suitable for production use. Semver says it's a new minor version (because we're pre-1.0.0). @ozkatz WDYT?

[arielshaqed]

How can this happen?

[guy-har]

@arielshaqed
This could happen if the repository is configured with a different namespace.
Will happen due to wrong configuration (that we currently aloud).
Or, for example, an old repository that was configured when we where using S3, and then we changed to local

[arielshaqed]

Approved once release note is ready to go.