Change graveler iterator interface #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
force-pushed
the
feature/iterator-phase-2
branch
from
dd397d0 to
af7cc3b
Compare
itaiad200
force-pushed
the
feature/iterator-phase-2
branch
from
af7cc3b to
127de37
Compare
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 46.24% 46.24%
=======================================
Files 152 152
Lines 12308 12305 -3
=======================================
- Hits 5692 5691 -1
+ Misses 5893 5892 -1
+ Partials 723 722 -1
Continue to review full report at Codecov.
|
ozkatz
approved these changes
Dec 8, 2020
| // initPhase turns true when the iterator was created or `SeekGE()` was called. | ||
| // initPhase turns false when Next() is called. | ||
| // When initPhase is true, Value() should return nil. | ||
| initPhase bool |
There was a problem hiding this comment.
why not use the value? it's nil when you initialize, it makes sense to set it to nil when you SeekGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.