Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial implementation of Graveler #1019

Merged
merged 16 commits into from
Dec 13, 2020
Merged

Add initial implementation of Graveler #1019

merged 16 commits into from
Dec 13, 2020

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Dec 8, 2020

No description provided.

@guy-har guy-har requested a review from nopcoder December 8, 2020 18:15
@codecov-io
Copy link

codecov-io commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #1019 (d4cbf9e) into master (11a13f8) will increase coverage by 0.15%.
The diff coverage is 50.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage   46.21%   46.36%   +0.15%     
==========================================
  Files         152      156       +4     
  Lines       12318    12666     +348     
==========================================
+ Hits         5693     5873     +180     
- Misses       5901     6039     +138     
- Partials      724      754      +30
Impacted Files Coverage Δ
export/export_handler.go 20.70% <ø> (ø)
parade/action_manager.go 80.76% <ø> (ø)
graveler/graveler.go 33.17% <30.68%> (-6.30%) ⬇️
graveler/combined_iterator.go 56.14% <56.14%> (ø)
graveler/uncommitted_diff_iterator.go 61.36% <61.36%> (ø)
graveler/prefix_iterator.go 80.00% <80.00%> (ø)
graveler/listing_iterator.go 92.15% <92.15%> (ø)
graveler/pgrefs.go 72.60% <100.00%> (ø)
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
catalog/mvcc/cataloger_create_branch.go 81.53% <0.00%> (-3.08%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a13f8...d4cbf9e. Read the comment docs.

nopcoder
nopcoder suggested changes Dec 9, 2020
View reviewed changes
graveler/gravel.go Outdated Show resolved Hide resolved
graveler/gravel.go Outdated Show resolved Hide resolved
graveler/gravel.go Outdated Show resolved Hide resolved
graveler/gravel.go Outdated Show resolved Hide resolved
graveler/gravel.go Outdated Show resolved Hide resolved
nopcoder
nopcoder suggested changes Dec 9, 2020
View reviewed changes
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
graveler/graveler_test.go Outdated Show resolved Hide resolved
nopcoder
nopcoder reviewed Dec 9, 2020
View reviewed changes
graveler/graveler_test.go Outdated Show resolved Hide resolved
nopcoder
nopcoder reviewed Dec 9, 2020
View reviewed changes
graveler/graveler_test.go Outdated Show resolved Hide resolved
@guy-har guy-har requested a review from nopcoder December 9, 2020 14:00
nopcoder
nopcoder suggested changes Dec 10, 2020
View reviewed changes
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/combined_iterator.go Outdated Show resolved Hide resolved
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler.go Show resolved Hide resolved
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/uncommitted_diff_iterator.go Outdated Show resolved Hide resolved
graveler/uncommitted_diff_iterator.go Outdated Show resolved Hide resolved
graveler/uncommitted_diff_iterator.go Outdated Show resolved Hide resolved
graveler/uncommitted_diff_iterator.go Outdated Show resolved Hide resolved
graveler/uncommitted_diff_iterator.go Outdated Show resolved Hide resolved
guy-har and others added 9 commits December 10, 2020 13:28
@guy-har @nopcoder
Update graveler/uncommitted_diff_iterator.go
feebf51 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har @nopcoder
Update graveler/combined_iterator.go
dc53534 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har @nopcoder
Update graveler/graveler.go
7204b81 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har @nopcoder
Update graveler/listing_iterator.go
b068659 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har @nopcoder
Update graveler/graveler.go
6dd8c41 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har @nopcoder
Update graveler/uncommitted_diff_iterator.go
9e32e2c 
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
@guy-har
Add change requests from review
c452f59
@guy-har
Merge remote-tracking branch 'origin/feature/gravel_initial' into fea…
1e94992 
…ture/gravel_initial

# Conflicts:
#	graveler/graveler.go
@guy-har
Add change requests from review
7d632f3
@guy-har guy-har requested a review from nopcoder December 13, 2020 11:39
nopcoder
nopcoder reviewed Dec 13, 2020
View reviewed changes
graveler/graveler.go Outdated Show resolved Hide resolved
graveler/graveler_mock_test.go Outdated Show resolved Hide resolved
nopcoder
nopcoder approved these changes Dec 13, 2020
View reviewed changes
graveler/graveler_test.go Show resolved Hide resolved
graveler/graveler_mock_test.go Show resolved Hide resolved
graveler/listing_iterator.go Outdated Show resolved Hide resolved
graveler/listing_iterator.go Outdated Show resolved Hide resolved
@guy-har guy-har changed the title initial implementation of Graveler Add initial implementation for Graveler Dec 13, 2020
@guy-har guy-har changed the title Add initial implementation for Graveler Add initial implementation of Graveler Dec 13, 2020
@guy-har guy-har merged commit ec39a82 into master Dec 13, 2020
@guy-har guy-har deleted the feature/gravel_initial branch December 13, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 left review comments

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guy-har @codecov-io @nopcoder @itaiad200