Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway branch name validation #1024

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix gateway branch name validation #1024

merged 1 commit into from
Dec 9, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 9, 2020

No description provided.

@nopcoder nopcoder added the bug Something isn't working label Dec 9, 2020
@nopcoder nopcoder requested a review from ozkatz December 9, 2020 18:00
@nopcoder nopcoder self-assigned this Dec 9, 2020
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assiming this section will be refactored soon, LGTM :)

@codecov-io
Copy link

Codecov Report

Merging #1024 (28efa7b) into master (d8f2060) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         152      152           
  Lines       12315    12315           
=======================================
  Hits         5695     5695           
  Misses       5895     5895           
  Partials      725      725           
Impacted Files Coverage Δ
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
catalog/mvcc/cataloger_create_branch.go 84.61% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f2060...28efa7b. Read the comment docs.

@nopcoder nopcoder merged commit 4895fae into master Dec 9, 2020
@nopcoder nopcoder deleted the bugfix/valid-branch branch December 9, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants