Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid int cast without limit check #1038

Merged
merged 1 commit into from
Dec 10, 2020
Merged

avoid int cast without limit check #1038

merged 1 commit into from
Dec 10, 2020

Conversation

nopcoder
Copy link
Contributor

No description provided.

@nopcoder nopcoder self-assigned this Dec 10, 2020
@nopcoder nopcoder requested a review from itaiad200 December 10, 2020 11:53
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks...

@codecov-io
Copy link

Codecov Report

Merging #1038 (7c2ed47) into master (b173443) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   46.26%   46.22%   -0.04%     
==========================================
  Files         152      152              
  Lines       12315    12316       +1     
==========================================
- Hits         5697     5693       -4     
- Misses       5894     5897       +3     
- Partials      724      726       +2     
Impacted Files Coverage Δ
gateway/operations/listobjects.go 0.00% <0.00%> (ø)
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
catalog/mvcc/cataloger_create_branch.go 81.53% <0.00%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b173443...7c2ed47. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request fixes 1 alert when merging 7c2ed47 into ffd75a0 - view on LGTM.com

fixed alerts:

  • 1 for Incorrect conversion between integer types

@nopcoder nopcoder merged commit 211afbb into master Dec 10, 2020
@nopcoder nopcoder deleted the chore/avoid-int-cast branch December 10, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants