Allow lakectl to run without a config file #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
added
the
pr/merge-if-approved
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 46.17% 46.24% +0.07%
==========================================
Files 152 152
Lines 12316 12318 +2
==========================================
+ Hits 5687 5697 +10
+ Misses 5903 5896 -7
+ Partials 726 725 -1
Continue to review full report at Codecov.
|
nopcoder
reviewed
Dec 10, 2020
nopcoder
reviewed
Dec 13, 2020
cmd/lakectl/cmd/root.go
Outdated
| @@ -41,7 +41,11 @@ lakectl is a CLI tool allowing exploration and manipulation of a lakeFS environm | |||
| return | |||
| } | |||
| if _, ok := cfgFileErr.(viper.ConfigFileNotFoundError); ok { | |||
There was a problem hiding this comment.
if len(cfgFile) > 0 && errors.As(cfgFileErr, &viper.ConfigFileNotFoundError{}) {
There was a problem hiding this comment.
This is also inaccurate as it will catch the second condition for cfgFileErr != nil.
Refactored again.
itaiad200
force-pushed
the
feature/lakectl-no-file
branch
from
6e92a12 to
757b868
Compare
itaiad200
force-pushed
the
feature/lakectl-no-file
branch
from
757b868 to
0c60671
Compare
nopcoder
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.