Add Azure adapter #1444
Merged
Add Azure adapter #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyaug
reviewed
Feb 10, 2021
block/factory/build.go
Outdated
| @@ -5,6 +5,10 @@ import ( | |||
| "errors" | |||
| "fmt" | |||
|
|
|||
| "github.com/Azure/azure-storage-blob-go/azblob" | |||
|
|
|||
block/azure/chunkwriting.go
Outdated
| } | ||
| // write block sizes | ||
| sd := strconv.Itoa(int(cp.reader.CopiedSize)) + "\n" | ||
| _, err = cp.toSizes.StageBlock(cp.ctx, base64Etag, strings.NewReader(sd), cp.o.AccessConditions.LeaseAccessConditions, nil, cp.o.ClientProvidedKeyOptions) |
There was a problem hiding this comment.
Suggestion:
Use a struct:
type PartInfo struct {
blockIDs []string `json:"block_ids"`
size int `json:"size"`
}Then, have just one file for all the blockInfos, and read it with one method and not two.
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 39.86% 39.05% -0.81%
==========================================
Files 156 159 +3
Lines 12478 12828 +350
==========================================
+ Hits 4974 5010 +36
- Misses 6795 7101 +306
- Partials 709 717 +8
Continue to review full report at Codecov.
|
nopcoder
suggested changes
Feb 15, 2021
nopcoder
suggested changes
Feb 15, 2021
nopcoder
reviewed
Feb 15, 2021
nopcoder
reviewed
Feb 15, 2021
nopcoder
suggested changes
Feb 15, 2021
nopcoder
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.