-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/openapi3 #1667
Feature/openapi3 #1667
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 39.87% 41.64% +1.76%
==========================================
Files 171 168 -3
Lines 13957 13315 -642
==========================================
- Hits 5566 5545 -21
+ Misses 7609 7029 -580
+ Partials 782 741 -41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Trying to grow this mega-PR. Just skimmed swagger.yml, mostly to show my ignorance. Happy for comments that will tell me what is most urgent for me to read first, the better to review this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't gone thru it all yet.. looking great so far
Merged the client upload-related changes - the wrapper code above the client API is gone so I've added it to the client's fs.go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks very nice.
Partial comments; will do the rest after rebase is pushed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, very nice!
Required changes:
- Upload errors are handled unsafely in
lakectl
-- succeed on unknown error.
Additional (meta-) comments:
- The "WithResponses" client interface is quite nasty. Maybe just not use it? (Not necessary in this PR)
// Find route | ||
route, pathParams, err := router.FindRoute(r) | ||
if err != nil { | ||
return http.StatusBadRequest, err // We failed to find a matching route for the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REST says there is no such difference; I have to agree with @itaiad200 here. 400
is always appropriate (because it says so little), however accessing a URL that is not mounted is a classic 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Please review whether we wnat to return 404 for an unknown path in validateRequest
. Any which way, I think this is good (great..) to go!
🎉 |
🎉🎉
…On Fri, Apr 2, 2021, 9:31 AM Oz Katz ***@***.***> wrote:
🎉
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1667 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANM7PU3CTV6IDO6DFZPJ47LTGVQDFANCNFSM4ZTMPDIA>
.
|
Using OpenAPI3 using https://github.com/deepmap/oapi-codegen
Modified the server template code to parse incoming body in case of one body in JSON format.
Removed the python code which verifies the schema, it is not compatible with v3.
TODOs