Avoid logging v2 sigs on failure #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auth headers are inherently unsafe: if Eve can read (just) headers and can guess message contents, then she can fix a broken message and replay it slightly later. Easiest just to avoid logging bad headers. If there is a problem record the actual HTTP requests and responses on the client and send them out of band.
arielshaqed
added
the
pr/merge-if-approved
|
Found by LGTM.com. |
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
=======================================
Coverage 39.44% 39.44%
=======================================
Files 167 167
Lines 13616 13616
=======================================
Hits 5371 5371
Misses 7483 7483
Partials 762 762
Continue to review full report at Codecov.
|
ozkatz
approved these changes
Mar 25, 2021
|
This pull request fixes 1 alert when merging 4a76a30 into 2c07fcb - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth headers are inherently unsafe: if Eve can read (just) headers and can guess message
contents, then she can fix a broken message and replay it slightly later.
Easiest just to avoid logging bad headers. If there is a problem record the actual HTTP
requests and responses on the client and send them out of band.