fix: API merge message is optional #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
+ Coverage 41.64% 41.67% +0.03%
==========================================
Files 168 168
Lines 13316 13319 +3
==========================================
+ Hits 5545 5551 +6
+ Misses 7030 7027 -3
Partials 741 741
Continue to review full report at Codecov.
|
arielshaqed
approved these changes
Apr 4, 2021
| @@ -1777,6 +1775,30 @@ paths: | |||
| required: true | |||
| schema: | |||
| type: string | |||
| get: | |||
There was a problem hiding this comment.
This seems to be off by one, it incorporates a previous change into this swaggacopy but not this change. Can you regenerate it before pulling?
There was a problem hiding this comment.
sure - I was sure the makefile validates they are the same.
There was a problem hiding this comment.
% sha256sum api/swagger.yml docs/assets/js/swagger.yml
9674aad548414c911e7c7d21f22bae22632e9c6e9f7784875549eb74917c34f4 api/swagger.yml
9674aad548414c911e7c7d21f22bae22632e9c6e9f7784875549eb74917c34f4 docs/assets/js/swagger.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix backward compatibility for merge request