Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Python Client #1725

Merged
merged 14 commits into from
Apr 11, 2021
Merged

OpenAPI Python Client #1725

merged 14 commits into from
Apr 11, 2021

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Apr 6, 2021

Part of #1725
Changes made to the project Makefile to generate the python client code.
Added:

  • clients/python/lakefs/client.py to enable a single client with access to all APIs
  • clients/python/build-package.sh to build pypi package

@nopcoder nopcoder self-assigned this Apr 6, 2021
@nopcoder nopcoder requested a review from ozkatz April 6, 2021 13:29
@nopcoder nopcoder marked this pull request as ready for review April 6, 2021 13:32
@codecov-io
Copy link

codecov-io commented Apr 6, 2021

Codecov Report

Merging #1725 (ae9f62d) into master (e4554b9) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head ae9f62d differs from pull request most recent head 2a8db58. Consider uploading reports for the commit 2a8db58 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
- Coverage   41.60%   41.46%   -0.15%     
==========================================
  Files         168      170       +2     
  Lines       13319    13422     +103     
==========================================
+ Hits         5542     5565      +23     
- Misses       7035     7114      +79     
- Partials      742      743       +1     
Impacted Files Coverage Δ
pkg/metastore/hive/ms_client.go 30.43% <0.00%> (-2.90%) ⬇️
pkg/api/helpers/errors.go 81.81% <0.00%> (ø)
pkg/api/helpers/upload.go 0.00% <0.00%> (ø)
pkg/pyramid/tier_fs.go 58.51% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4554b9...2a8db58. Read the comment docs.

@nopcoder nopcoder requested review from itaiad200 and removed request for ozkatz April 8, 2021 12:20
.github/workflows/goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/pypi.yaml Outdated Show resolved Hide resolved
.github/workflows/pypi.yaml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
clients/python/.gitignore Show resolved Hide resolved
clients/python/.gitlab-ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@nopcoder nopcoder merged commit 5106950 into master Apr 11, 2021
@nopcoder nopcoder deleted the feature/python-client branch April 11, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants