Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List repository actions should not check branch existence #1743

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Apr 11, 2021

Fix #1727

Removed the check for branch exist for list actions runs.
To fix the test code was required to pass the same block adapter from our catalog to all of other services used by our controller test code.

@nopcoder nopcoder self-assigned this Apr 11, 2021
@nopcoder nopcoder force-pushed the bugfix/actions-list branch from 490bb0b to 2299340 Compare April 14, 2021 09:48
@nopcoder nopcoder marked this pull request as ready for review April 14, 2021 09:53
@nopcoder nopcoder requested a review from arielshaqed April 14, 2021 09:54
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

pkg/api/controller_test.go Outdated Show resolved Hide resolved
pkg/api/controller_test.go Outdated Show resolved Hide resolved
@nopcoder nopcoder requested a review from arielshaqed April 14, 2021 10:52
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Your solution for indentation looking horrible is much simpler & better than my proposal :-)

@nopcoder nopcoder merged commit 88a159e into master Apr 14, 2021
@nopcoder nopcoder deleted the bugfix/actions-list branch April 14, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: list actions by branch after branch delete should return old runs
2 participants