Fix auth pagination #1755
Merged
Fix auth pagination #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by fixing the test (to look at >1 word), and also by paging with amount 2 and examining the `next_offset` field. Fixes #1748.
Previously was always `false`, so paging was never flagged. Tested by listing: ``` go run ./cmd/lakectl -c ~/.lakectl.nessie.yaml auth users list --amount 2 --after five +---------+-------------------------------+ | USER ID | CREATION DATE | +---------+-------------------------------+ | four | 2021-04-12 13:29:20 +0300 IDT | | nessie | 2021-04-11 17:07:59 +0300 IDT | +---------+-------------------------------+ for more results run with --amount 2 --after "nessie" ``` The line "for more results..." never used to appear!
auth paginator cannot handle table-decorated column names, it looks for the a field with an exact tag name. Avoid unnecessary adornment of the table from which a column comes. It is (by definition!) not needed to describe the column, which is how the unadorned `db:...` tag works.
johnnyaug
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1748 as well as two subsequently-discovered (smaller) bugs.