Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/parquet inventory failure #1979

Merged
merged 4 commits into from
May 23, 2021
Merged

Bugfix/parquet inventory failure #1979

merged 4 commits into from
May 23, 2021

Conversation

johnnyaug
Copy link
Contributor

@johnnyaug johnnyaug commented May 20, 2021 •
edited
Loading

Solves #1952

@johnnyaug johnnyaug requested a review from nopcoder May 20, 2021 17:09
nopcoder
nopcoder approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to simplify the code

pkg/cloud/aws/s3inventory/parquet_reader.go Outdated
func (p *ParquetInventoryFileReader) getKeyColumnStatistics() *parquet.Statistics {
for i, c := range p.Footer.RowGroups[0].Columns {
func (p *ParquetInventoryFileReader) getKeyColumnStatistics(rowGroupIdx int) *parquet.Statistics {
for i, c := range p.Footer.RowGroups[rowGroupIdx].Columns {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify by replacing all occurrences:

	columns := p.Footer.RowGroups[rowGroupIdx].Columns

and inside the loop:

	metaData := c.GetMetaData()

@johnnyaug johnnyaug merged commit 36eb6ae into master May 23, 2021
@johnnyaug johnnyaug deleted the bugfix/parquet_inventory_failure branch May 23, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyaug @nopcoder