Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway on get without version should return after error #1990

Merged
merged 1 commit into from
May 26, 2021
Merged

gateway on get without version should return after error #1990

merged 1 commit into from
May 26, 2021

Conversation

nopcoder
Copy link
Contributor

Fix #1989

@nopcoder nopcoder requested a review from arielshaqed May 24, 2021 10:32
@nopcoder nopcoder self-assigned this May 24, 2021
@nopcoder nopcoder added the bug Something isn't working label May 24, 2021
arielshaqed
arielshaqed approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. THANKS!

@nopcoder nopcoder merged commit 4589933 into master May 26, 2021
@nopcoder nopcoder deleted the fix/error-return branch May 26, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway get object without version encode two errors in response
2 participants
@nopcoder @arielshaqed