Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix adapter qualified key format to not use path.Join #1994

Merged
merged 1 commit into from
May 31, 2021
Merged

fix adapter qualified key format to not use path.Join #1994

merged 1 commit into from
May 31, 2021

Conversation

nopcoder
Copy link
Contributor

Fix #1861

@nopcoder nopcoder requested a review from ozkatz May 24, 2021 11:35
@nopcoder nopcoder self-assigned this May 24, 2021
@nopcoder nopcoder added bug Something isn't working area/block-adapter labels May 24, 2021
@arielshaqed arielshaqed changed the title fix adapter qulified key format to not use path.Join fix adapter qualified key format to not use path.Join May 30, 2021
@nopcoder nopcoder requested a review from arielshaqed May 31, 2021 09:16
arielshaqed
arielshaqed approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Much) better!

@nopcoder nopcoder removed the request for review from ozkatz May 31, 2021 13:41
@nopcoder nopcoder merged commit bc06ea5 into master May 31, 2021
@nopcoder nopcoder deleted the fix/path-clean branch May 31, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
area/block-adapter bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objects with physical address containing dots or slashes return an incorrect physical address
2 participants
@nopcoder @arielshaqed