make authorization errors readable in the UI, change /config to require re fs permissions since it returns storage config #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guy-har
approved these changes
Jun 3, 2021
@guy-har for reference, see https://github.com/treeverse/lakeFS/blob/master/pkg/ddl/000024_actions_auth_policies.up.sql - I use the exact same logic with a different policy. |
…re fs permissions since it returns storage config
ozkatz
force-pushed
the
fix/2028-uninformative-auth-errors
branch
from
28ee852 to
fa643f3
Compare
|
@arielshaqed see breaking change ( |
arielshaqed
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Cool; thanks! I shall update #2002 to use getStorageConfig and compute the warnings locally.
api/swagger.yml
Outdated
| operationId: getConfig | ||
| description: retrieve the lakefs config | ||
| operationId: getStorageConfig | ||
| description: retrieve the lakefs storage configuration |
There was a problem hiding this comment.
Suggested change
| description: retrieve the lakefs storage configuration | |
| description: retrieve lakeFS storage configuration |
(and elsewhere).
| --log-format string set logging output format | ||
| --log-level string set logging level (default "none") | ||
| --log-output string set logging output file | ||
| --no-color don't use fancy output colors (default when not attached to an interactive terminal) |
There was a problem hiding this comment.
These all seem unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2028