add lakefs version to ui #2088
Merged
add lakefs version to ui #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
requested changes
Jun 13, 2021
arielshaqed
reviewed
Jun 13, 2021
api/swagger.yml
Outdated
| content: | ||
| application/json: | ||
| schema: | ||
| type: string |
There was a problem hiding this comment.
This should be an object. That way we can add more details, e.g. API versions, plugin versions, etc.
Passing a primitive or an array as the entire JSON response is somewhat similar to "primitive obsession", and can be particularly nasty in APIs.
arielshaqed
approved these changes
Jun 13, 2021
| @@ -694,7 +694,11 @@ components: | |||
| type: string | |||
| blockstore_namespace_ValidityRegex: | |||
| type: string | |||
|
|
|||
| VersionConfig: | |||
There was a problem hiding this comment.
nit:
Suggested change
| VersionConfig: | |
| VersionConfig: |
talSofer
reviewed
Jun 13, 2021
api/swagger.yml
Outdated
| description: get version of lakeFS server | ||
| responses: | ||
| 200: | ||
| description: lakeFS storage configuration |
There was a problem hiding this comment.
The description is incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2077