lakefs config.yaml align name and search order #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
requested review from
arielshaqed
and removed request for
arielshaqed
arielshaqed
requested changes
Aug 17, 2021
There was a problem hiding this comment.
Great! I don't understand why we search explicitly for the config file in the home directory after configuring Viper to search for it anyway; see comment inline.
The above is not necessarily blocking. Requested changes are all in documentation:
- Please document the location of the configuration file.
- Please add a row to
CHANGELOG.md, this change is (very) user-visible.
nopcoder
force-pushed
the
chore/service-config
branch
2 times, most recently
from
a7d6ed9 to
bf2784d
Compare
nopcoder
force-pushed
the
chore/service-config
branch
from
ce23397 to
48b5dc0
Compare
- configuration file named lakefs.yaml - search for /etc/lakefs/config.yaml - search for $HOME/.lakefs/config.yaml - search for ./config.yaml - (fallback) search for $HOME/.lakefs.yaml
Co-authored-by: arielshaqed <ariels@treeverse.io>
nopcoder
force-pushed
the
chore/service-config
branch
from
d4f28f5 to
acbc3bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lakefs service configuration - align the filename and search locations to other services, with fallback support:
Close #2355